Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: partially implement semantic highlight #36

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: partially implement semantic highlight #36

wants to merge 2 commits into from

Conversation

rszyma
Copy link
Owner

@rszyma rszyma commented Jun 10, 2024

Describe the changes and why are you making them

Closes: #34

Checklist

  • Update CHANGELOG.md

@rszyma
Copy link
Owner Author

rszyma commented Jun 10, 2024 •
edited
Loading

todo:

  • fix semantic highlight not working the first time it's activated (race condition, need to wait for files to load first)
  • make this feature optional, opt-in for the time being, becuase this is not a full semantic highlight. For example numbers in actions e.g. in one-shot still don't get highlighted properly. Also it stops working when there's an error in config, disappearing coloring might be annoying.
  • fix this bug - probably something wrong with unicode handling
    image

@rszyma rszyma changed the title refactor: move server init params to rust feat: semantic highlight Jun 10, 2024
@rszyma rszyma changed the title feat: semantic highlight feat: (partial) semantic highlight Jun 10, 2024
@rszyma rszyma changed the title feat: (partial) semantic highlight feat: partial semantic highlight Jun 10, 2024
@rszyma
add config option for semantic hightlight
ac175f6 
disabled by default and marked as expermental, because of bugs
@rszyma rszyma changed the title feat: partial semantic highlight feat: partially implement semantic highlight Jun 10, 2024
@rszyma rszyma marked this pull request as draft October 13, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: semantic highlighting
1 participant
@rszyma